Assertion fixes #3
Conversation
Added condition for APP sourced sessions. APP sessions don't need to have landing page (as WEB based sessions do), but they should always have an APP Id
Added condition to elimnate fresh table stream suffixes being included in date compare (timeliness assertion)
|
@iamnutzy1975 thank you for this patch! Also: thank you for your patience! This is the first outside code that is contributed to us, and it took us a while to find time to build a process around this. Are you OK with signing a Contributor License Agreement? This is a super small patch, but size is not always important - we value your contribution greatly. |
|
Hi Jules,
Signed agreement attached.
Let me know of anything else required to push my changes into the main
branch.
Gord
…On Thu, May 1, 2025 at 7:56 AM Jules ***@***.***> wrote:
*zjuul* left a comment (superformlabs/ga4dataform-community#3)
<#3 (comment)>
@iamnutzy1975 <https://github.com/iamnutzy1975> thank you for this patch!
The current assertions are indeed assuming no fresh tables exist, and that
there is always something as landing_page.
Also: thank you for your patience! This is the first outside code that is
contributed to us, and it took us a while to find time to build a process
around this.
Are you OK with signing a Contributor License Agreement?
Explanation can be found here:
https://ga4dataform.com/contributing-to-ga4dataform/
This is a super small patch, but size is not always important - we value
your contribution greatly.
You won't have to sign it for every contribution, just once is enough.
After that, you're an Official Contributor to the project :)
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLZWNZEAJ32DNTSYMKFENL24IRZXAVCNFSM6AAAAAB2IES66WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBUHA4TENJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi Gord, I totally missed your reply - somehow I did not receive a notification and the attachment is not attached, it is sent straight to github and discarded there(?) Can you please email it directly to [email protected] ? Thank you so much for your patience! |
2 participants
I had installed GA4Dataform for 7 different GA4 properties and I was commonly seeing errors with assertions due to session valadility and timeliness. I tracked it down to "fresh" tables and APP sessions.
I tested these changes by overriding the CORE assertion file and creating my own CUSTOM version where I installed GA4 Data Form - fixed and no issues were the result.
Therefore, I decide to share my fixes so that hopefully that make it into the CORE product.